feat(prompts): support a visible status for un-hiding components #74228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #74228 +/- ##
==========================================
- Coverage 79.94% 78.13% -1.82%
==========================================
Files 6836 6665 -171
Lines 307457 297923 -9534
Branches 51252 51281 +29
==========================================
- Hits 245808 232772 -13036
+ Misses 61225 58876 -2349
- Partials 424 6275 +5851
|
aliu39
added a commit
that referenced
this pull request
Jul 16, 2024
…74236) Depends on #74228 Relates to #74209 Adds a button to the "User Feedback" section of issue details page. Allows members to hide/unhide feedback from **all** issue details in a project. Persists this decision across reloads using the prompt backend Updated demo with chevron/drop-down style hiding: https://github.com/user-attachments/assets/43a02a63-98c0-42bd-8651-f1baeeb22218 Updated loading indicator: (you can see for a split sec at :12) https://github.com/user-attachments/assets/a2d57c51-e459-467b-9a9c-5e227050d9b7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #74209. We're using the prompt backend to persist a user's decision to hide/unhide user feedback in the issue details page. The goal is to be able to toggle between promptIsDismissed = true/false.